Some more per owner things by oli-obk · Pull Request #157100 · rust-lang/rust

oli-obk · 2026-05-29T08:50:46Z

A few easy ones to turn from a global hash table to a hash table (or even a bool) per owner, but still have to check perf first.

r? @petrochenkov

oli-obk · 2026-05-29T08:50:56Z

@bors try @rust-timer queue

Some more per owner things

rust-bors · 2026-05-29T11:00:34Z

☀️ Try build successful (CI)
Build commit: 40871fa (40871faace74f2aa45e2b2d4233be219fcb14d30, parent: dc375db7d8df0aa450e622c529147c95eee756f5)

rust-timer · 2026-05-29T11:41:47Z

Finished benchmarking commit (40871fa): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	1
Regressions ❌ (secondary)	0.6%	[0.1%, 1.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	2
All ❌✅ (primary)	0.1%	[0.1%, 0.1%]	1

Max RSS (memory usage)

Results (primary -4.0%, secondary 2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.6%	[1.5%, 10.2%]	10
Improvements ✅ (primary)	-4.0%	[-6.2%, -1.7%]	2
Improvements ✅ (secondary)	-7.3%	[-9.3%, -5.4%]	2
All ❌✅ (primary)	-4.0%	[-6.2%, -1.7%]	2

Cycles

Results (primary 3.6%, secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.6%	[2.2%, 5.0%]	2
Regressions ❌ (secondary)	3.8%	[2.5%, 6.6%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.6%	[2.2%, 5.0%]	2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 510.27s -> 510.262s (-0.00%)
Artifact size: 400.65 MiB -> 400.65 MiB (-0.00%)

oli-obk · 2026-05-29T12:59:01Z

Spurious CI network failure.
Perf is just noise

petrochenkov · 2026-05-29T13:06:40Z

@bors r+ rollup=maybe

rust-bors · 2026-05-29T13:06:44Z

📌 Commit b69baba has been approved by petrochenkov

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@petrochenkov

…, r=petrochenkov Some more per owner things A few easy ones to turn from a global hash table to a hash table (or even a bool) per owner, but still have to check perf first. r? @petrochenkov

…uwer Rollup of 9 pull requests Successful merges: - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`) - #157053 (Eagerly resolve delegations in late resolution) - #157068 (NVPTX: Remove the unstable ptx linker flavor) - #157076 (Various proc-macro related code cleanups) - #157100 (Some more per owner things) - #157065 (Stabilize `Path::is_empty`) - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros) - #157088 (Improve suggestions for malformed deprecated attribute) - #157103 (Add reproducibly failing tests for parallel frontend)

…uwer Rollup of 11 pull requests Successful merges: - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering) - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`) - #157053 (Eagerly resolve delegations in late resolution) - #157068 (NVPTX: Remove the unstable ptx linker flavor) - #157076 (Various proc-macro related code cleanups) - #157106 (add ABI check logic for wasm) - #154835 (std::offload sharedmem) - #157065 (Stabilize `Path::is_empty`) - #157070 (Remove `skip_arg` attribute from `Diagnostic` and `Subdiagnostic` proc-macros) - #157088 (Improve suggestions for malformed deprecated attribute) - #157103 (Add reproducibly failing tests for parallel frontend) Failed merges: - #157100 (Some more per owner things)

…uwer Rollup of 11 pull requests Successful merges: - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error) - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering) - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`) - #157053 (Eagerly resolve delegations in late resolution) - #157068 (NVPTX: Remove the unstable ptx linker flavor) - #157076 (Various proc-macro related code cleanups) - #157106 (add ABI check logic for wasm) - #154835 (std::offload sharedmem) - #157065 (Stabilize `Path::is_empty`) - #157088 (Improve suggestions for malformed deprecated attribute) - #157103 (Add reproducibly failing tests for parallel frontend) Failed merges: - #157100 (Some more per owner things)

…uwer Rollup of 16 pull requests Successful merges: - #149195 (resolve: Partially convert `ambiguous_glob_imports` lint into a hard error) - #156960 (Some cleanups around passing extra lifetime params from the resolver to ast lowering) - #156963 (definitions: remove `DefPathTable`, use `LocalDefId` instead of `DefIndex`) - #157053 (Eagerly resolve delegations in late resolution) - #157068 (NVPTX: Remove the unstable ptx linker flavor) - #157076 (Various proc-macro related code cleanups) - #157106 (add ABI check logic for wasm) - #154835 (std::offload sharedmem) - #157065 (Stabilize `Path::is_empty`) - #157088 (Improve suggestions for malformed deprecated attribute) - #157098 (Add the `clflushopt` x86 target feature) - #157103 (Add reproducibly failing tests for parallel frontend) - #157111 (Update target maintainer for x86_64-unknown-linux-none) - #157116 (rustc_public: add `with_cx()` to `CompilerInterface`) - #157119 (ast_lowering: Simplify `resolve_pin_drop_sugar_impl_item`) - #157120 (Cleanups around attribute target checking) Failed merges: - #157100 (Some more per owner things)

@petrochenkov

…, r=petrochenkov Some more per owner things A few easy ones to turn from a global hash table to a hash table (or even a bool) per owner, but still have to check perf first. r? @petrochenkov

…n()` syntax registrations of it, they are never used

rustbot · 2026-05-30T08:16:31Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

oli-obk · 2026-05-30T08:16:55Z

@bors r=petrochenkov

rust-bors · 2026-05-30T08:16:58Z

📌 Commit b7ea5d8 has been approved by petrochenkov

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

…uwer Rollup of 12 pull requests Successful merges: - #154591 (Remove `will_cache_on_disk_for_key_fn`) - #156672 (Misc improvements to coroutine transform code) - #157027 (HIR ty lowering: Move some things into submodules) - #157051 (Allow two object files for a single CGU in CompiledModule) - #157100 (Some more per owner things) - #153497 (Use `trait_object_dummy_self` more & heavily fix+update related docs) - #155638 (Fix tupled closure signature in `AsyncFn` arg mismatch diagnostic) - #156826 (style: Clarify nullary call and `()` no-break rule applies past max width) - #157004 (Remove unused functions in `value_analysis.rs`) - #157032 (Fixed more &x ->&mut x suggestions) - #157033 (Note irrefutable while let in loop type errors) - #157139 (compiler: `ops::RangeInclusive` → `range::RangeInclusive`) Failed merges: - #156875 (Correct and document semantics of `yield` terminator)

rustbot assigned petrochenkov May 29, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 29, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 29, 2026

Auto merge of #157100 - oli-obk:some_more_per_owner_things, r=<try>

40871fa

Some more per owner things

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 29, 2026

oli-obk marked this pull request as ready for review May 29, 2026 12:58

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 29, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2026

JonathanBrouwer mentioned this pull request May 29, 2026

Rollup of 9 pull requests #157109

Closed

JonathanBrouwer mentioned this pull request May 29, 2026

Rollup of 11 pull requests #157113

Closed

JonathanBrouwer mentioned this pull request May 29, 2026

Rollup of 11 pull requests #157114

Closed

JonathanBrouwer mentioned this pull request May 29, 2026

Rollup of 16 pull requests #157121

Merged

JonathanBrouwer mentioned this pull request May 30, 2026

Rollup of 9 pull requests #157142

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 30, 2026

This comment has been minimized.

Sign in to view

oli-obk added 4 commits May 30, 2026 10:09

Use default field values to avoid some churn

e83d369

Track lifetime_elision_allowed per owner, and discard fn ptr and `F…

fec4545

…n()` syntax registrations of it, they are never used

Track label_res_map per-owner

5b37028

Track lifetimes_res_map per owner

b7ea5d8

oli-obk force-pushed the some_more_per_owner_things branch from b69baba to b7ea5d8 Compare May 30, 2026 08:16

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 30, 2026

JonathanBrouwer mentioned this pull request May 30, 2026

Rollup of 12 pull requests #157149

Merged

rust-bors Bot merged commit b7856de into rust-lang:main May 30, 2026
12 checks passed

rustbot added this to the 1.98.0 milestone May 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Some more per owner things#157100

Some more per owner things#157100
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
oli-obk:some_more_per_owner_things

oli-obk commented May 29, 2026

Uh oh!

oli-obk commented May 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 29, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2026

Uh oh!

oli-obk commented May 29, 2026

Uh oh!

petrochenkov commented May 29, 2026

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

This comment has been minimized.

rustbot commented May 30, 2026

Uh oh!

oli-obk commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

oli-obk commented May 29, 2026

Uh oh!

oli-obk commented May 29, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented May 29, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 29, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

oli-obk commented May 29, 2026

Uh oh!

petrochenkov commented May 29, 2026

Uh oh!

rust-bors Bot commented May 29, 2026

Uh oh!

This comment has been minimized.

rustbot commented May 30, 2026

Uh oh!

oli-obk commented May 30, 2026

Uh oh!

rust-bors Bot commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants